Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): Fix loading shown when host list is empty #527

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Jan 31, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • UI bug where hosts lists shows loading empty state when empty.
  • Issue where useHostFilters is set to 'true' by default and then only can change state if hosts > 0

Which issue(s) this PR fixes:

Issue noticed on initial deployment by @jabbate19

Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a97366) 70.54% compared to head (aa069d8) 70.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #527   +/-   ##
=======================================
  Coverage   70.54%   70.54%           
=======================================
  Files         126      126           
  Lines        9590     9590           
=======================================
  Hits         6765     6765           
  Misses       2678     2678           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 merged commit cd7ac2e into main Jan 31, 2024
8 checks passed
@cmp5987 cmp5987 deleted the cp-bug-host-view branch January 31, 2024 21:38
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
fix(bug): Fix loading shown when host list is empty (#527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants