Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Process List Reporting #574

Merged
merged 3 commits into from
Feb 11, 2024
Merged

[feature] Process List Reporting #574

merged 3 commits into from
Feb 11, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Enables us to report process lists, also fixes an entgo generation bug with HostProcess.

Which issue(s) this PR fixes:

Fixes #

@KCarretto KCarretto requested a review from hulto February 11, 2024 02:14
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (1c8eff8) 70.32% compared to head (e8a5321) 70.88%.

Files Patch % Lines
implants/lib/eldritch/src/report/mod.rs 78.08% 16 Missing ⚠️
...lants/lib/eldritch/src/report/process_list_impl.rs 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   70.32%   70.88%   +0.56%     
==========================================
  Files         139      141       +2     
  Lines       10149    10225      +76     
==========================================
+ Hits         7137     7248     +111     
+ Misses       2846     2811      -35     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing that seems a bit weirdge but other than that gucci

@@ -25,15 +25,6 @@ resolver:
# ent package. If they match it will use them, otherwise it will new ones.
autobind:
- realm.pub/tavern/internal/ent
- realm.pub/tavern/internal/ent/file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all of the autobind types are just located in 'ent/'

@KCarretto KCarretto merged commit 05a2be7 into main Feb 11, 2024
8 checks passed
@KCarretto KCarretto deleted the reporting branch February 11, 2024 17:08
nullmonk pushed a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants