Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] starlark -> 0.12.0, rust -> 1.76.0 #578

Merged
merged 7 commits into from
Feb 12, 2024
Merged

[cleanup] starlark -> 0.12.0, rust -> 1.76.0 #578

merged 7 commits into from
Feb 12, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Upgrades rust to 1.76.0
  • Upgrades starlark to 0.12.0

@hulto
Copy link
Collaborator

hulto commented Feb 12, 2024

Stable 👀

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (580f5cd) 70.78% compared to head (67b0956) 71.28%.

Files Patch % Lines
implants/golem/src/inter/eval.rs 57.14% 15 Missing ⚠️
implants/lib/eldritch/src/process/list_impl.rs 63.63% 4 Missing ⚠️
implants/lib/eldritch/src/sys/get_user_impl.rs 60.00% 4 Missing ⚠️
implants/lib/eldritch/src/file/follow_impl.rs 0.00% 3 Missing ⚠️
implants/lib/eldritch/src/pivot/port_scan_impl.rs 50.00% 3 Missing ⚠️
implants/golem/src/inter/types.rs 0.00% 2 Missing ⚠️
implants/lib/eldritch/src/process/info_impl.rs 71.42% 2 Missing ⚠️
implants/lib/eldritch/src/sys/get_env_impl.rs 60.00% 2 Missing ⚠️
implants/lib/eldritch/src/sys/get_reg_impl.rs 84.61% 2 Missing ⚠️
implants/lib/eldritch/src/runtime/exec.rs 87.50% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   70.78%   71.28%   +0.49%     
==========================================
  Files         141      141              
  Lines       10184    10092      -92     
==========================================
- Hits         7209     7194      -15     
+ Misses       2809     2732      -77     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -261,28 +265,32 @@ jobs:
upload_golem_windows:
name: 🚀 [Windows] Golem
needs: create_release # Depends on release being created for upload URL
runs-on: windows-latest
runs-on: ubuntu-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love some stability 😎

@KCarretto KCarretto merged commit 67970e2 into main Feb 12, 2024
7 of 8 checks passed
@KCarretto KCarretto deleted the upgrade-rust branch February 12, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants