Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Credential Reporting #585

Merged
merged 5 commits into from
Feb 13, 2024
Merged

[feature] Credential Reporting #585

merged 5 commits into from
Feb 13, 2024

Conversation

KCarretto
Copy link
Collaborator

@KCarretto KCarretto commented Feb 13, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds a new HostCredential ent
  • Adds a new report_credential gRPC API method
  • Adds a new report.user_password() eldritch method
  • Adds a new report.ssh_key() eldritch method
  • Moves generated protobuf definitions to `generated directories
  • Updates eldritch File protobuf to have uint64 size field

Which issue(s) this PR fixes:

Fixes #543

@KCarretto KCarretto requested a review from hulto February 13, 2024 03:19
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KCarretto KCarretto merged commit 88fcaa4 into main Feb 13, 2024
6 checks passed
@KCarretto KCarretto deleted the admin-delete-mutation branch February 13, 2024 05:53
nullmonk pushed a commit that referenced this pull request Feb 14, 2024
* added dropAllData admin mutation

* added credential API

* added report.user_password() eldritch method

* added report.ssh_key() eldritch method

---------

Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Credentials Reporting
3 participants