Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Import Tomes from git #603

Merged
merged 16 commits into from
Feb 18, 2024
Merged

[feature] Import Tomes from git #603

merged 16 commits into from
Feb 18, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new GraphQL Mutation which will import tomes from the provided git URI.

@KCarretto KCarretto requested a review from hulto February 16, 2024 23:14
hulto
hulto previously approved these changes Feb 17, 2024
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Optionally, specify directories to include.
Only tomes that have a main.eldritch in one of these directory prefixes will be included.
"""
includeDirs: [String!]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this search recursizely? Eg do i need to specify:
gitURL: https://github.com/spellshift/realm
includeDirs: ["tavern/tomes/"]

  • or -
    includeDirs: ["tavern/tomes/cat","/tavern/tomes/hostname",...]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tavern/tomes/, all it does is a prefix match

tavern/tomes/git.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (e1ca31b) 71.53% compared to head (aca3f16) 71.18%.

Files Patch % Lines
tavern/tomes/git.go 60.62% 42 Missing and 21 partials ⚠️
tavern/internal/graphql/mutation.resolvers.go 0.00% 21 Missing ⚠️
tavern/tomes/parse.go 26.31% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   71.53%   71.18%   -0.35%     
==========================================
  Files         167      168       +1     
  Lines       11002    11199     +197     
==========================================
+ Hits         7870     7972     +102     
- Misses       2953     3023      +70     
- Partials      179      204      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KCarretto KCarretto merged commit a4671b3 into main Feb 18, 2024
6 of 8 checks passed
@KCarretto KCarretto deleted the github-imports branch February 18, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants