Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cp show error #608

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Cp show error #608

merged 2 commits into from
Feb 17, 2024

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Feb 17, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds ability to see errors
  • Adds error count to quest view
  • Adds error badge to tasks
  • Adds error counts to dashboard

Screenshots

Screenshot 2024-02-17 at 3 20 29 PM Screenshot 2024-02-17 at 3 20 24 PM Screenshot 2024-02-17 at 3 20 19 PM Screenshot 2024-02-17 at 3 20 03 PM

@cmp5987 cmp5987 added feature New feature or request Frontend labels Feb 17, 2024
@cmp5987 cmp5987 requested a review from hulto February 17, 2024 20:23
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (598f9cc) 71.59% compared to head (550a58a) 71.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   71.59%   71.59%           
=======================================
  Files         167      167           
  Lines       10993    10993           
=======================================
  Hits         7870     7870           
  Misses       2944     2944           
  Partials      179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 merged commit ad5fe2f into main Feb 17, 2024
8 checks passed
@cmp5987 cmp5987 deleted the cp-show-error branch February 17, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants