Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable f-strings for fun #612

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Enable f-strings for fun #612

merged 1 commit into from
Feb 18, 2024

Conversation

Cictrone
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Life, Liberty, and the pursuit of f"reedom

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's F-inf go!!!
🤌🤌

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a4671b3) 71.18% compared to head (dba617c) 71.24%.

Files Patch % Lines
implants/lib/eldritch/src/pivot/port_scan_impl.rs 90.00% 1 Missing ⚠️
implants/lib/eldritch/src/sys/shell_impl.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   71.18%   71.24%   +0.06%     
==========================================
  Files         168      168              
  Lines       11199    11224      +25     
==========================================
+ Hits         7972     7997      +25     
  Misses       3023     3023              
  Partials      204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cictrone Cictrone merged commit 0d29fb2 into main Feb 18, 2024
8 checks passed
@Cictrone Cictrone deleted the f-strings branch February 18, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants