Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add newline #613

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Re-add newline #613

merged 6 commits into from
Feb 20, 2024

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Feb 18, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Print has an implicit newline.

Which issue(s) this PR fixes:

Fixes #573

@hulto hulto linked an issue Feb 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7569cca) 67.92% compared to head (5b77902) 71.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
+ Coverage   67.92%   71.20%   +3.27%     
==========================================
  Files         170      170              
  Lines       10924    11500     +576     
==========================================
+ Hits         7420     8188     +768     
+ Misses       3290     3098     -192     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulto hulto merged commit 2c320c8 into main Feb 20, 2024
8 checks passed
@hulto hulto deleted the 573-bug-print-function-is-not-to-spec branch February 20, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Print function is not to spec
3 participants