We support proxies woot #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
- Coverage 71.95% 71.65% -0.31%
==========================================
Files 175 175
Lines 12251 12287 +36
==========================================
- Hits 8815 8804 -11
- Misses 3221 3268 +47
Partials 215 215 ☔ View full report in Codecov by Sentry. |
Cictrone
previously approved these changes
Mar 10, 2024
Cictrone
reviewed
Mar 15, 2024
| @@ -100,13 +113,52 @@ impl Default for Config { | |||
| "failed to parse retry interval constant, defaulting to 5 seconds: {_err}" | |||
| ); | |||
|
|
|||
| 5_u64 | |||
| 5 | |||
There was a problem hiding this comment.
is there a reason we removed the type hint?
There was a problem hiding this comment.
Yeah it confused me and I deleted it broke everything and so this is my attempt to confuse less ppl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds support for http and https proxies in Imix
Which issue(s) this PR fixes:
fixes #705