-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pep8 check to CI #234
Comments
I think the only modification required will be to replace |
Minor addition here -- I also like (as xarray does) running the test suite with the |
I think we may also need to add |
Potentially better command to use: https://github.com/pydata/xarray/pull/1741/files#diff-354f30a63fb0907d4ad57269548329e3R94 |
Indeed that is cleaner. If we go that route we may want to fix all the existing flake8 issues first :) |
@spencerkclark Do you just mean fixing #238? |
@micahkim23 sorry for being a little vague; I still consider #238 as a separate issue. I meant that if we go with @spencerahill's suggestion we are no longer running Currently it flags the following issues:
Apparently some tools exist that can help automate this process, but I have not used them before: |
I must say, I'm actually quite pleased that we had that few PEP8 violations in the codebase 😄 |
Let's leave the style nitpicks to the robots. Should be easily able to adapt xarray's here: https://github.com/pydata/xarray/blob/master/.travis.yml#L94
The text was updated successfully, but these errors were encountered: