Fix packaging of examples #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, misread the docs on including scripts before the most recent commit; hopefully this one fixes it (Nice example of CI saving my tail) |
|
Blargh forgot to rename the example notebook...this time it should really work 😜 |
|
@spencerahill all good! Any interest in checking out pytest-ipynb to have Travis always check to make sure the example notebook runs? I came across it yesterday, as it's used in OceanPARCELS/parcels in their Travis build process: https://travis-ci.org/OceanPARCELS/parcels/builds/191243567 |
|
@spencerkclark nice find! That would be very cool to eventually get configured. Will open an issue for it. Will merge once AppVeyor finishes, barring any objections |
|
Yes, this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149 plus a few other minor edits