Deprecate CalcInterface #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
approved these changes
Dec 18, 2017
There was a problem hiding this comment.
Indeed this does seem pretty straightforward! It looks like you just need to merge with the latest master branch and you should be good.
Edit: obviously you're well aware of the need to merge and as you note above, of course it's the develop branch in our case :)
aospy/automate.py
Outdated
| @@ -237,7 +236,7 @@ def _combine_core_aux_specs(self): | |||
|
|
|||
| def create_calcs(self): | |||
| """Generate a Calc object for each requested parameter combination.""" | |||
| return [Calc(CalcInterface(**sp)) for sp in | |||
| return [Calc(**sp) for sp in | |||
There was a problem hiding this comment.
Could this fit on one line now?
|
Very weird, this test is passing on my local machine... |
|
Disregard previous comment; hadn't pushed latest changes. In it goes! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C.f. #249. Turns out this was easier than I thought it would be.
Although I accidentally forgot to pull the latest commits to my local develop branch before creating this branch, so I'll have to resolve the merge conflicts manually.
Given how easy this was, I'm inclined to proceed with it.