-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grid_attrs argument to Model constructor #297
Conversation
Thanks for speeding this through @spencerkclark! I should have time on Friday to properly review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the caveat that I'm a little rusty at thinking carefully about the codebase, I actually think the implementation looks good as is. A couple minor docs suggestions is all.
Awesome --- this looks ready to go @spencerkclark . Merge whenever you're ready, and thanks as always for the great work. |
@spencerahill one more minor update for you to have a look at; I added a reference table to the documentation showing the current built-in alternative names (I think it's a bit tricky for new users to find those at the moment). Let me know if that looks good and I'll go ahead and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea on the table. One tiny edit; go ahead and merge once that's done.
Thanks for the review @spencerahill; merging now! |
Closes #182