End-to-end test module #61
Conversation
|
From first glance this looks great. I'll take a closer look soon. Thanks! |
|
|
||
| if __name__ == '__main__': | ||
| suite = unittest.TestLoader().loadTestsFromTestCase(TestAospy) | ||
| unittest.TextTestRunner(verbosity=2).run(suite) |
There was a problem hiding this comment.
What's the motivation behind these calls? I think the idiom for the main block of test modules is just unittest.main() (see e.g. test_utils.py).
There was a problem hiding this comment.
No real motivation here; this is more or less just carried over from me experimenting with different levels of verbose output from the unittest module. I have no issues making this more consistent with the other test modules already defined in aospy.
| import runs | ||
|
|
||
|
|
||
| am2 = Model( |
There was a problem hiding this comment.
Here and elsewhere that has GFDL-specific files, we might want to put in some try/except guards such that these don't cause the overall aospy testing suite to crash from non-GFDL machines (thinking about this led me to open #62).
For the tests themselves, we can use unittest's skip decorators.
There was a problem hiding this comment.
Let me know if 973d868 addresses this to your liking. It's not as general as we might like (since the test doesn't just look for the grid files, it also looks for the olr files), but I think it is sufficient to determine whether a test is only possible to be run in the GFDL environment.
|
Other than my in-line comments, this looks great and works for me from an ssh. Out of curiosity I cloned it to my laptop also, and the result is just a failure of test_am2_annual_mean with This PR, combined with #63, will give me so much more piece of mind moving forward. |
|
Yes, this works perfectly -- skips that test on my local machine, and test runs and passes at GFDL. Thanks a lot! |
This is a start of a minimal end-to-end testing module (as discussed in #42). Currently I've just included a test of one project, one model, one run, and one model-native variable. The structure is based off comments in pull request 43 and further developments in spencerkclark/aospy-db#2.
There is ample room to make this more comprehensive, but I want to get the basic structure down first. (This is meant to replace pull request 43; rather than modify the existing one, I thought it might be cleaner to start fresh).
Please let me know if you have any comments or suggestions. Thanks!