Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other types of constrained figures #15

Closed
spencerkclark opened this issue Jan 6, 2018 · 0 comments · Fixed by #32
Closed

Add support for other types of constrained figures #15

spencerkclark opened this issue Jan 6, 2018 · 0 comments · Fixed by #32

Comments

@spencerkclark
Copy link
Owner

Currently only width is enabled as a constraint. While for me this has been the most common use case, there are at least two other conceivable use-cases:

  • A height-constrained figure with a fixed aspect ratio (and flexible width)
  • A width and height constrained figure, with a flexible aspect ratio.

Internally I think it makes sense to create separate classes for these other types of constraints; we'll have to think a little more carefully how we might want to expose them in the interface. It could be something as simple as which keyword arguments one specifies (out of width, height, and aspect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant