Britishize asymmetry with Americanize

[AbhinavMadahar]

On version 1.1.3

If you try typing in something like

require("nlp_compromise").britishize("color");
> "color"

require("nlp_compromise").britishize("favorite");
> "favorite"

require("nlp_compromise").britishize("internationalization");
> "internationalization"

It just returns whatever the input is.

The americanize function works perfectly fine, though.

[AbhinavMadahar]

Also, it when converting from British to American, it will make "are" to "aer" using the logic that "metre" becomes "meter"

[spencermountain]

haha! thanks Abhinav. It is way stronger going one way than the other. I'll take a look at improving this, and that bug, this week.
cheers

[DanielBaird]

Shot in the dark: maybe try britishise() ?

[spencermountain]

with the new api (released this week), it's mostly the same call

var nlp=require("nlp_compromise")
t=nlp.term("favorite")
console.log(t.britishize())

although the asymmetry between britishize and americanize remains. it just needs some work.

[nathanmarks]

@spencermountain Here's a demo with a few terms not working as hoped:

1. britishization not working
2. britishization not working
3. americanization works
4. americanization incorrect

https://tonicdev.com/569fd5d4a6f5cc0d0018195d/569fd5d4ff73f00e00779a00

[spencermountain]

ah, rats. k thanks.
i'll take a look
thought: should it be renamed to 't.toAmerican(), t.toBritish()'?
or something else?

[nathanmarks]

@spencermountain xxxxxxxx-ize seems to be the norm for a lot of functions in "inflection" libs (dasherize, humanize, camelize, parameterize). FWIW Americanization is a thing which is a nice touch.

[spencermountain]

;) copy that.

[spencermountain]

locale was removed from this repo a couple months ago, so will close this ticket.
hope to get back into it though, one day