Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix types resolution for node16 / bundler #393

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix types resolution for node16 / bundler #393

merged 1 commit into from
Jul 28, 2023

Conversation

meowtec
Copy link
Contributor

@meowtec meowtec commented Jul 27, 2023

If nodeResolution in tsconfig.json is set to Node16 NodeNext or Bundler, TypeScript (tested on version 5.1.6) will throw error:

import spacetime from 'spacetime';

'spacetime' is declared but its value is never read.ts(6133)
Could not find a declaration file for module 'spacetime'.

@jecraig
Copy link
Contributor

jecraig commented Jul 27, 2023

Looks to work correctly for Node16 and continues to run with the older Node setting.

Fixes #356
Thanks

@spencermountain
Copy link
Owner

thank you! I'll release this tomorrow morning.
cheers

@spencermountain spencermountain merged commit 84f8845 into spencermountain:master Jul 28, 2023
@spencermountain spencermountain mentioned this pull request Jul 28, 2023
Merged
@spencermountain
Copy link
Owner

released as 7.4.5 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meowtec @jecraig @spencermountain