Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in wikitext can lead to big chunks of HTML commented out #184

Closed
j-rausch opened this issue Sep 19, 2018 · 2 comments
Closed

Comments in wikitext can lead to big chunks of HTML commented out #184

j-rausch opened this issue Sep 19, 2018 · 2 comments

Comments

@j-rausch
Copy link
Contributor

I noticed that wikitext snippets containing <! -- can cause problems in the generated HTML documents, if they are not closed properly. This can lead to huge chunks of documents missing and/or invalid htmls.

An example:
Snippets such as

Mech Guard #1, Wealthy Jock || || <ref name="btva"/><!-- <ref>{{cite AV media | at=Closing credits | title=[[Batman Unlimited: Animal Instincts]] | year=2015 | medium=film}}</ref>  -->

in https://en.wikipedia.org/w/index.php?title=Matthew_Mercer&action=edit&editintro=Template:BLP_editintro
will lead to this html section, which is missing the comment end:

...
 <td><span class="sentence">Mech Guard #1, Wealthy Jock</span></td> 
<td><span class="sentence"></span></td> 
<td><span class="sentence"><! --></span></td>
</tr> 

The same problem is caused by lines such as <!-- NEED ROLE CITED and <!-- NEED SOURCE AND NOTABILITY in the wikitext of the same article.

@spencermountain
Copy link
Owner

yikes, thank you.
will check it out

@spencermountain
Copy link
Owner

fixed in 6.2.0
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants