Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revenue, net_income and other properties of info_box are wrongly parsed when they follow USD template without space #375

Closed
nico008 opened this issue Jun 29, 2020 · 6 comments

Comments

@nico008
Copy link
Contributor

nico008 commented Jun 29, 2020

Hi spencermountain,
It's been a while!
I believe I just found a problem on version 8.3:
In some cases, the parser will return USD.627 billion instead of USD115.627 billion.
Example:
https://en.wikipedia.org/w/index.php?title=JPMorgan_Chase&action=edit
Could it be because there is no space between the USD template and the number?
Example:
| revenue = {{increase}} [[United States dollar|US$]]115.627 [[Billion (short scale)|billion]]
I suspect this problem also apply to other templates, potentially out of the Infobox as well.
I would really appreciate if this could be fixed.
Thanks a lot!
Nicolas

@spencermountain
Copy link
Owner

hey @nico008 good find.
yup, can reproduce:

let doc = wtf(`[[US]]9999.2`)
console.log(doc.text())
// 'US.2'

will take a look, thanks.

spencermountain added a commit that referenced this issue Jun 29, 2020
@nico008
Copy link
Contributor Author

nico008 commented Jul 3, 2020

Thank you! Could you give an ETA when a new version would be available?
This would help a lot!

@spencermountain
Copy link
Owner

next week

@spencermountain
Copy link
Owner

got this on my list to do tomorrow
thanks for your patience

@spencermountain
Copy link
Owner

released as 8.4.0
cheers

@nico008
Copy link
Contributor Author

nico008 commented Jul 12, 2020

Hi @spencermountain,
I updated to version 8.4.0 and I can confirm your fix is working good !
Thank you so much for quick release.
Be well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants