Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected how tasks were being passed through to the executeCommand call for subtasks #66

Merged
merged 1 commit into from Jun 1, 2023
Merged

Corrected how tasks were being passed through to the executeCommand call for subtasks #66

merged 1 commit into from Jun 1, 2023

Conversation

spencerwmiles
Copy link
Owner

Fixes #65

@spencerwmiles spencerwmiles linked an issue May 31, 2023 that may be closed by this pull request
Subtasks not working #65
Closed
@spencerwmiles
Copy link
Owner Author

Screen.Recording.2023-05-31.at.7.12.58.AM.mov

@spencerwmiles
Copy link
Owner Author

@gameguy682 @FaBjE if one of you guys don't mind, lets try and get this out today.

@gameguy682
Copy link
Collaborator

Code looks fine (on mobile), but I want to test this to make sure things are working.

gameguy682
gameguy682 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@gameguy682 gameguy682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look on a break at work. LGTM!

@gameguy682 gameguy682 merged commit 5b935a4 into production Jun 1, 2023
@gameguy682 gameguy682 deleted the 65-subtasks-not-working branch June 1, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gameguy682 gameguy682 gameguy682 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subtasks not working
2 participants
@spencerwmiles @gameguy682