Skip to content
This repository has been archived by the owner on Jan 1, 2022. It is now read-only.

Fix preview case compatible #22

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Fix preview case compatible #22

merged 2 commits into from
Aug 27, 2020

Conversation

LufsX
Copy link
Contributor

@LufsX LufsX commented Aug 27, 2020

Fixes #21

@spencerwooo
Copy link
Owner

啊我刚看到，一直没时间说这个事情，不必这样的，你直接在提取 file extension - ./src/index.js#L88 这里 tolower() 就好了。等我有空改下，或者你 PR 一下。这个 PR 里这么改太浪费感情了……

@spencerwooo
Copy link
Owner

spencerwooo commented Aug 27, 2020 •
edited

对不起，是 .toLowerCase()，写 Python 写多了……

EDIT：淦，Python 直接是 lower()，算了，我太菜了 (o_ _)ﾉ

@spencerwooo spencerwooo self-assigned this Aug 27, 2020
@spencerwooo spencerwooo added bug Something isn't working enhancement New feature or request labels Aug 27, 2020
@LufsX
Copy link
Contributor Author

LufsX commented Aug 27, 2020

啊我刚看到，一直没时间说这个事情，不必这样的，你直接在提取 file extension - ./src/index.js#L88 这里 tolower() 就好了。等我有空改下，或者你 PR 一下。这个 PR 里这么改太浪费感情了……

啊, 是我太菜了😂️

嗯, 改好了

@spencerwooo spencerwooo mentioned this pull request Aug 27, 2020
Open
@spencerwooo
Copy link
Owner

应该没问题的吧，我就不本地测了（莽一波）

@spencerwooo spencerwooo merged commit 274376b into spencerwooo:master Aug 27, 2020
@LufsX
Copy link
Contributor Author

LufsX commented Aug 27, 2020

应该没问题的吧，我就不本地测了（莽一波）

没问题的说

@LufsX LufsX deleted the preview branch October 3, 2020 06:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spencerwooo spencerwooo spencerwooo approved these changes

Assignees

@spencerwooo spencerwooo

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File extension parsing is case-sensitive
2 participants
@LufsX @spencerwooo