feat: add soundcloud embed #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
spences10
approved these changes
May 3, 2022
|
Awesome! Thanks |
|
Oh! Hey, I need to add some contributing docs actually! Would you like to add an example to the |
|
Sure :D That's one question I had: which Soundcloud track do you want to showcase on the index page? :D |
|
Yeah, sure, I was just adding in the example actually! Regarding the rest of the configuration, awesome that SoundCloud have a Widget-API! Feel free to contribute more if you like, I'd appreciate it for sure! I've added in an example using the component on the index for now, if you want to add more feel free, thanks. I'm just about to publish your change now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #174
Hey Scott 👋 First of all I really like the idea of your package.
I'm having the following two questions
In case you aren't interested in adding SoundCloud, feel free to close the PR 👍 🛹