Create Generic Embed Component #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @Cahllagerfeld, thanks. So, couple of things, I think the component name as The use of the props is something I'll need to do something with, maybe add a component to take care of the props and usage. |
|
Thanks man! I've just moved it over to MDSvex because I wanted to add usage and that was the best way I could come up with 😊 I'll be keeping my eye on https://github.com/leveluptuts/bookit though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #178 and adds a generic component to the library.
I added the Component to the Index Page as well and turned it into a Spotify Version. I tried to document how the component works inside a comment within the code preview, not sure if that's how it's supposed to be though.
Feel free to give some feedback on this 👍