Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Fortran legacy/modern #135

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Conversation

jake-87
Copy link
Contributor

@jake-87 jake-87 commented Aug 28, 2023

Couldn't find the template.
See: #34 (comment)

@jake-87 jake-87 requested a review from o2sh as a code owner August 28, 2023 22:04
@spenserblack spenserblack changed the title FORTRANs. Support Fortran legacy/modern Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #135 (6c8f2ba) into main (fcb51ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files          12       12           
  Lines         486      486           
=======================================
  Hits          425      425           
  Misses         61       61           
Flag Coverage Δ
87.44% <ø> (ø)
macOS-latest 87.22% <ø> (-0.22%) ⬇️
ubuntu-latest 83.54% <ø> (ø)
windows-latest 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@spenserblack spenserblack enabled auto-merge (squash) August 28, 2023 23:11
@jake-87
Copy link
Contributor Author

jake-87 commented Aug 28, 2023

Apologies for the mistaken alphabet - Wasn't sure what convention you were following.

@spenserblack spenserblack merged commit 1f75c9f into spenserblack:main Aug 28, 2023
11 checks passed
@spenserblack
Copy link
Owner

No worries, that's why the CI is there. I'm just following how Ruby alphabetizes, but basically it's special characters, then uppercase, then lowercase. If you want to get technical, they're ordered by char code points 🙂

@spenserblack
Copy link
Owner

And thanks again! This really helps us out in getting onefetch to finally be able to handle languages with conflicting extensions.

spenserblack added a commit to o2sh/onefetch that referenced this pull request Aug 29, 2023
@spenserblack spenserblack added the new-language Requests to add a new language label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-language Requests to add a new language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants