Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GDScript #234

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Support GDScript #234

merged 1 commit into from
Oct 23, 2023

Conversation

alexpalade
Copy link
Contributor

GDScript is a programming language built for the Godot game engine. (docs, Wikipedia)

Example output screenshot.

Appears on #34

@alexpalade alexpalade requested a review from o2sh as a code owner October 23, 2023 17:39
@spenserblack spenserblack enabled auto-merge (squash) October 23, 2023 18:25
@spenserblack spenserblack added the new-language Requests to add a new language label Oct 23, 2023
Copy link
Owner

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Are you participating in Hacktoberfest?

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #234 (86796ec) into main (09c82d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files          16       16           
  Lines         580      580           
=======================================
  Hits          482      482           
  Misses         98       98           
Flag Coverage Δ
83.10% <ø> (ø)
macOS-latest 82.84% <ø> (ø)
ubuntu-latest 78.84% <ø> (ø)
windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@spenserblack spenserblack merged commit 6d663a9 into spenserblack:main Oct 23, 2023
11 checks passed
@spenserblack
Copy link
Owner

@all-contributors add @alexpalade for data

@allcontributors
Copy link
Contributor

@spenserblack

I've put up a pull request to add @alexpalade! 🎉

@alexpalade
Copy link
Contributor Author

Are you participating in Hacktoberfest?

Yes! 🎃👻 Btw, there's no need for a hacktoberfest-accepted label since the repository has the hacktoberfest topic. 🙂 The PR already shows up on the Hacktoberfest dashboard.

@spenserblack
Copy link
Owner

Yes! 🎃👻 Btw, there's no need for a hacktoberfest-accepted label since the repository has the hacktoberfest topic. 🙂 The PR already shows up on the Hacktoberfest dashboard.

Thanks for the info! But generated GitHub releases can actually use PR labels to categorize changes:
https://github.com/spenserblack/gengo/blob/b37593d00337321fc8f1df3f2f10d528ab58f1fe/.github/release.yml

So I was thinking of taking advantage of the labels to give a shout-out to all the hacktoberfest participants 🎃

@spenserblack spenserblack added the hacktoberfest-accepted Accepted hacktoberfest contributions label Oct 23, 2023
@alexpalade
Copy link
Contributor Author

That's nice! I had a feeling there was more to it. Thanks for being supportive. This was my 2nd PR and it's gratifying and fun.

@spenserblack
Copy link
Owner

Congrats on your 2nd PR! I bet there will be many more in the future 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted hacktoberfest contributions new-language Requests to add a new language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants