Use impl Trait instead of explicit generics
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the code a bit by simplifying some of the syntax, not not declaring explicit generics where they don't need to be declared. This is a breaking change because: - The implementation of a public trait has changed - The turbofish cannot be used on methods that use "anonymous" generics
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 17 17
Lines 595 595
=======================================
Hits 523 523
Misses 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the code a bit by simplifying some of the syntax, not not
declaring explicit generics where they don't need to be declared.
This is a breaking change because: