-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Language
enum
#298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
===========================================
- Coverage 87.88% 75.05% -12.83%
===========================================
Files 18 17 -1
Lines 619 425 -194
===========================================
- Hits 544 319 -225
- Misses 75 106 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
spenserblack
force-pushed
the
breaking/285/language-enum
branch
from
February 1, 2024 18:41
6d02633
to
51c5f65
Compare
spenserblack
force-pushed
the
breaking/285/language-enum
branch
from
February 6, 2024 15:47
55f85f8
to
5f54988
Compare
This makes the build script a bit easier to read and less complicated by focusing on release code.
spenserblack
added a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation from interpreting language definitions as compile-time to runtime.
This drastically changes the API, both by simplifying it using implementation that can only be used
with compile-time definitions, and also by removing APIs that are impossible without runtime
language definitions.
To do
Language
structLanguage
struct can be used in JSON output (privateLanguageAttrs
struct?)Analyzers::pick
withLanguage::pick
serde_json
andserde_yaml
dependencies on main crate (and anything else that runtime parsing depends on)