Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test parity with hashid.js #31

Closed
wants to merge 2 commits into from
Closed

improve test parity with hashid.js #31

wants to merge 2 commits into from

Conversation

matthewvalimaki
Copy link
Contributor

Adds bad-input and min-length tests from https://github.com/ivanakimov/hashids.js/tree/master/tests. bad-input revealed bug #30.

@matthewvalimaki matthewvalimaki mentioned this pull request Mar 23, 2017
Closed
@matthewvalimaki
Copy link
Contributor Author

hashid.js does not return errors but empty arrays (in Go's case []int{}, not nil) and that's why the other tests are tripping.

@speps
Copy link
Owner

speps commented May 9, 2017

Got most of your tests and fixed some of them, also closed #28 and #29: 2aa1a76

@speps speps closed this May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewvalimaki @speps