Merge pull request #3634 from achow101/avoid-list-mod

Avoid modifying self.transactions in prepare_for_verifier

lib/wallet.py

@@ -969,7 +969,7 @@ def prepare_for_verifier(self):
         # if we are on a pruning server, remove unverified transactions
         with self.lock:
             vr = list(self.verified_tx.keys()) + list(self.unverified_tx.keys())
-        for tx_hash in self.transactions.keys():
+        for tx_hash in list(self.transactions):
             if tx_hash not in vr:
                 self.print_error("removing transaction", tx_hash)
                 self.transactions.pop(tx_hash)