-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
show bip39 warning and add info about checksum disabled
- Loading branch information
Showing
1 changed file
with
19 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b194cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly disagree with disabling the checksum. Some checksum is better than none. It's only a matter of time before someone loses money because of a typo. The scenario is this: A user has an existing bip39 seed that he uses for cold storage... he inputs it on a cold storage machine to get an address, makes a typo, sends money to the wrong address, and then removes the wallet (because he knows the seed).
The chances of something like this happening are much higher than someone getting a false positive from a weak checksum. I don't understand the reasoning here... seems like a terrible decision!
8b194cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a "RECOVERY" method.
Your concern is only valid if:
Electrum's BIP39 is there SOLELY to assist Trezor (etc) users in case they lose their device. Which is recovery. Which means if they don't see money they'll just try again until they see their money.
8b194cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fyookball you are commenting on a commit that was later superseded.