Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels broken in 2.3.2 #1299

Closed
aussiehash opened this issue Jun 17, 2015 · 7 comments
Closed

Labels broken in 2.3.2 #1299

aussiehash opened this issue Jun 17, 2015 · 7 comments

Comments

@aussiehash
Copy link

Using the latest git pull on OSX

The "labels" function is completely broken (not using the label sync plugin)

  • opening an existing wallet created with Electrum 2.x initially displays the correct account names
    • changing electrum server wipes all account names
    • closing electrum and reopening wipes all account names
    • opening another wallet file wipes all account names
  • creating a new wallet > hardware wallet > trezor
    • all BIP32/39/44 wallets are listed with correct balances
    • renaming the "Main account" label, then renaming "Account 1" reverts the first label change
    • renaming any account label reverts the previous rename
    • closing electrum and reopening, no label changes are recorded.
  • the wallet file's has "labels" field is wiped by 2.3.2
    "labels": {},
@CyberDexter
Copy link

I do have labels but they are causing lag on busy wallets with syncing and I guess checking vs label sync if they are up to date and clicking on force up-/download in the plugin settings returns http://prntscr.com/7v13bp

Thus manually added labels will also not sync to co-owners.

@ghost
Copy link

ghost commented Aug 14, 2015

EDIT: Does not work, see it still reverts back after a while or after certain functions.

I found a solution to the problems with the labels.

Please see the post I made on bitcointalk.org

https://bitcointalk.org/index.php?topic=1152932.msg12140527#msg12140527

@aussiehash
Copy link
Author

Still broken with 2.4.1

@ecdsa
Copy link
Member

ecdsa commented Aug 15, 2015

isn't this a dupe of #1158 ?

@aussiehash
Copy link
Author

Well I'm not sure when the bug snuck in, it does not exist in the 2.0 beta releases. For example I think "seed 7" works fine.

ecdsa pushed a commit that referenced this issue Aug 17, 2015
@ecdsa ecdsa closed this as completed Aug 17, 2015
@aussiehash
Copy link
Author

Thanks ! Works perfectly.

@CyberDexter
Copy link

I was referencing tx labels not account labels. However this seems to be resolved, labels are now syncing fine for me. http://prntscr.com/87mwc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants