Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows build - update python-trezor #1846

Closed
prusnak opened this issue Jun 25, 2016 · 13 comments
Closed

windows build - update python-trezor #1846

prusnak opened this issue Jun 25, 2016 · 13 comments

Comments

@prusnak
Copy link
Contributor

prusnak commented Jun 25, 2016

please update bundled dependency of python-trezor to at least version 0.6.13 for windows build

this fixes issues with firmware 1.3.6 (it is unusable with older python-trezor) on windows

@slush0
Copy link
Contributor

slush0 commented Jul 1, 2016

@ecdsa Who to bribe to publish fixed Windows builds? :-) Lot of users are asking...

@ecdsa
Copy link
Member

ecdsa commented Jul 2, 2016

@slush0 is your last commit needed, or can it work with 2.6.4?

@ecdsa
Copy link
Member

ecdsa commented Jul 2, 2016

please test http://download.electrum.org/test/

@ecdsa
Copy link
Member

ecdsa commented Jul 2, 2016

<RainMan28> ThomasV: hi, just downloaded it. Still not detecting my trezor.
<RainMan28> the version number is still 2.6.4?
<ThomasV> any error message?
<RainMan28> No just that Could not connect to your TREZOR. Verify the cable is connected...

@ecdsa
Copy link
Member

ecdsa commented Jul 2, 2016

I guess it does not work because commit fdb810b is needed with recent versions of python-trezor. I cannot cherry-pick that commit in 2.6.4, it has conflicts.

If the trezor guys are willing to backport their patch to 2.6.4, I can try to create new builds. Otherwise it will need to wait until 2.7 is ready

@prusnak
Copy link
Contributor Author

prusnak commented Jul 2, 2016

As discussed with slush: Please do the rebuild of 2.6.x with python-trezor 0.6.13

0.7.0 is meant for master only.

@ecdsa
Copy link
Member

ecdsa commented Jul 2, 2016

ok, new binaries in http://download.electrum.org/test/ using 0.6.13
please test!

@Tisbox
Copy link

Tisbox commented Jul 2, 2016

@ecdsa; I just installed this new build over the previous 2.6.4. installation.
Results: everything works just fine again, so thank you for that.
What I tried was connecting the Trezor and then starting Electrum (Electrum now asked for the PIN again). Also I created a transaction to see if the Trezor could sign it correctly, and it did.
If there's anything else I can do for you (send logs or whatever) please let me know.

@ecdsa
Copy link
Member

ecdsa commented Jul 2, 2016

thanks for testing, I uploaded the binaries to the download page

@ecdsa ecdsa closed this as completed Jul 2, 2016
@prusnak
Copy link
Contributor Author

prusnak commented Jul 2, 2016

Thank you very much for prompt response.

@Aragonite
Copy link

Mac OS was spared this time - Trezor 1.3.6 and Electrum 2.6.4 playing well together...

@Tisbox
Copy link

Tisbox commented Jul 3, 2016

@ecdsa: shouldn't you release it as version 2.6.4a or 2.6.5 with the release note mentioning added support for Trezor firmware 1.3.6? Or at least on the download page mention the fact that the binaries are updated?
Because others who run in to the same problem and check the download page will think they already have the latest version while in fact they don't.

@ecdsa
Copy link
Member

ecdsa commented Jul 3, 2016

@Tisbox I made an announcement on twitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants