Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electrum (build-electrum-git.sh) does not build working windows binaries #2532

Closed
t4777sd opened this issue Jun 18, 2017 · 2 comments
Closed

Comments

@t4777sd
Copy link

t4777sd commented Jun 18, 2017

There is an issue with either the scripts or the instructions for building windows binaries from source. I have followed exact instructions starting from a fresh ubuntu installation with both Wine 1.6 (included with ubuntu) and Wine 2.01. The resultant binaries do not work. They are also 5MB smaller than the distributed versions, so either something is missing when installing from source with the instructions or something is added to the distributed versions.

Considering the readme in contrib/build-wine/ refers to "build-electrum.sh" which has not even existed since version 2.5 of electrum and has since been replaced by build-electrum-git.sh, I am pretty sure that the build instructions are lacking other relevant information.

Does anyone know what is missing in the instructions that cause a failed build? It appears to affect several userse: #2331

Steps to Build

  1. Download the source for 2.8.3 from github

  2. Install all the dependencies listed for linux to run it from the python code according to readme in root directory

  3. Run the following according to the readme in the root directory:
    ./contrib/make_packages

  4. Run the following according to the readme in ./contrib/build-wine/readme
    ./prepare-wine.sh
    ./prepare-hw.sh
    ./build-electrum-git.sh

Result
3 executables are created. Standalone, portable, and install. The Install executable will run the install process, but the resultant electrum executable does not work and immediately exit. The standalone / portable items also immediately exit.

@t4777sd
Copy link
Author

t4777sd commented Jun 19, 2017

Okay, I have made some progress. I ensured that module requests was version 2.5.1. That stopped some errors that I was seeing when I would run the resultant executable.

However, now that I did that I am getting a new error:

ImportError: No module named socks

I suspect this is similar to the "requests" module issue where past a certain version it does not work well with PyInstaller. Can anyone tell me what versions of all the modules that electrum is compiled with? That way I can compile a version that should match the distributed builds.

@t4777sd t4777sd closed this as completed Jun 19, 2017
@Kolabolla
Copy link

Considering you closed the issue, it looks like you found a fix? If so, what's the fix?

MrNaif2018 pushed a commit to MrNaif2018/electrum that referenced this issue Jan 15, 2023
Perform builds of AppImage, macOS, win and sourcedist on the master
branch each Monday 00:00:00 UTC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants