Consider restructuring the project modules (lib/gui/plugins)

[toxeus]

This is a minor issue but still worth reporting.

test_electrum_seed_2fa was added in this commit which imports plugins.trustedcoin which imports electrum and its submodules. As a consequence breaking changes in electrum or its submodules will not break the test until the electrum package is reinstalled. Even worse, a git pull might suddenly result in the test failing, assuming that the test and trustedcoin were changed.

[toxeus]

@SomberNight in my personal projects I use the following project structure which isn't affected at all by the problems electrum currently faces.

repo
├── script
├── pkg1
├── pkg2
└── ...

The hacks in the main script are not needed and the unit tests use the newest code from the repo because Python puts the directory containing the input script on top of its module search path (consequently pytest needs to be executed from the projects root dir; not sure if this is already the case).

For the electrum project the structure would therefore look like the following (only listing relevant files and folders).

electrum
├── electrum.py
├── electrum
├── electrum_gui
└── electrum_plugins

[SomberNight]

@ecdsa @ysangkok @bauerj
probably of interest to all of you

[SomberNight]

(context: #4286 (comment) )

[ysangkok]

@toxeus Try this: https://github.com/ysangkok/electrum/tree/file_layout_change

What do you think? I haven't used your suggested layout since it requires more hacks when there is no module that contains all relevant sources. This still needs to be tested on all platforms except Linux.

[toxeus]

@ysangkok sorry for the late reply. I don't know how to review 265 commits efficiently.

This branch seems to have different kinds of changes intermingled.

[ysangkok]

It's just one commit on top of a now-rebased lightning branch. But after reading your other comment, I don't see any particular problems with your approach.

[toxeus]

It's just one commit on top of a now-rebased lightning branch.

I see. Sorry for the misunderstanding then 😅

[ysangkok]

Fixed in 097ac14 . Thanks for the report.