Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't bump fees, float being passed to int_to_hex #5483

Closed
iDemonix opened this issue Jul 4, 2019 · 3 comments
Closed

Can't bump fees, float being passed to int_to_hex #5483

iDemonix opened this issue Jul 4, 2019 · 3 comments
Labels
bug 🐞 topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py

Comments

@iDemonix
Copy link

iDemonix commented Jul 4, 2019

When trying to bump a fee, Electrum crashes out with the following stack trace:

image

Looks like you're passing a float where an int is expected. This is in the latest 3.3.7 release, on Mac. I would have reported in the app, but:

image

@SomberNight SomberNight added bug 🐞 topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py labels Jul 4, 2019
@SomberNight
Copy link
Member

Thank you for reporting this. Looking into crash reporter issue now.

@SomberNight SomberNight reopened this Jul 4, 2019
@iDemonix
Copy link
Author

iDemonix commented Jul 4, 2019

Thanks, as a heads up it might be cool to include a link to GitHub issues on that message, so that if auto reporting fails, people know where to go.

@SomberNight
Copy link
Member

Indeed, good idea.

Crash report failure was related to us recently starting to use cloudflare; exception was:

E | gui.qt.exception_window.Exception_Window | There was a problem with the automatic reporting
Traceback (most recent call last):
  File "/home/user/wspace/electrum/electrum/gui/qt/util.py", line 716, in run
    result = task.task()
  File "/home/user/wspace/electrum/electrum/gui/qt/exception_window.py", line 113, in <lambda>
    task = lambda: BaseCrashReporter.send_report(self, self.main_window.network.asyncio_loop, proxy)
  File "/home/user/wspace/electrum/electrum/base_crash_reporter.py", line 73, in send_report
    response = asyncio.run_coroutine_threadsafe(coro, asyncio_loop).result(timeout)
  File "/usr/lib/python3.6/concurrent/futures/_base.py", line 432, in result
    return self.__get_result()
  File "/usr/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
  File "/home/user/wspace/electrum/electrum/base_crash_reporter.py", line 78, in do_post
    async with session.post(url, data=data) as resp:
  File "/home/user/wspace/electrum/packages/aiohttp/client.py", line 1005, in __aenter__
    self._resp = await self._coro
  File "/home/user/wspace/electrum/packages/aiohttp/client.py", line 528, in _request
    history[0].request_info, tuple(history))
aiohttp.client_exceptions.TooManyRedirects: 0, message=''

(will also add exception type to error message as 0, message='' is useless...)
For now, disabled cloudflare for this domain, will need to investigate more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py
Projects
None yet
Development

No branches or pull requests

2 participants