qml invoice dialog, onchain payment, cannot click Pay while editing amount

[accumulator]

allow click Pay while editing amount (if valid)

[ecdsa]

Another issue with the current buttons is that the user is allowed to edit the amount, even if the invoice contains an amount.
With the current GUI, I can receive a lightning invoice for a certain amount and modify that amount. I have not tested what happens if I click pay, but I guess nothing good :-)

The amount should be frozen if the invoice contains an amount, editable otherwise. There is no need for buttons that enable and disable editing.

[accumulator]

The problem is, once the amount is edited, it is stored in the invoice. So after setting an amount, it would become uneditable, even if the original invoice had no amount specified (e.g. address only 'invoice', no-amount LN invoice, etc).

We can work around it and keep the original amount around, but only as long as the wallet is open.

[ecdsa]

I don't understand what you mean...
I can still edit non-zero lightning amount after this commit: a571451
it does not seem to have an effect on the saved invoice, but that is not the point.
the point is: why would we want to let users edit that amount at all?

[accumulator]

I can still edit non-zero lightning amount after this commit: a571451

Yes that commit is not blocking edits, it is a fix for this issue. We should create a separate issue for your additional comment.

it does not seem to have an effect on the saved invoice, but that is not the point. the point is: why would we want to let users edit that amount at all?

scan address, amount is unspecified. Edit amount, save invoice -> amount is fixed.

[ecdsa]

Maybe I was not clear, but I do understand that it is useful to edit amounts when no amount is specified. this is not the point...

The reason why I did not open a separate issue is, I do not see why the editing widgets are useful at all. Their purpose is to switch between editing mode and non-editing mode. But my point is that there is no reason to ever switch between those modes. Thus, I think a deeper rework of InvoiceDialog is needed, that would remove all those buttons, and probably fix all issues at once.

[accumulator]

I can remove the edit mode toggle and just present the invoice amount OR the edit mode if no amount is specified.
However my point is what to do with the Save button. Do we just save the original invoice, or do we want to save with the user-entered amount?

[ecdsa]

we should save the entered amount if the original invoice did not have an amount.

[accumulator]

see 24a3d6e
not yet saving user entered amount

[ecdsa]

not yet saving user entered amount

I will try to fix that. any issue I should know?