-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qml invoice dialog, onchain payment, cannot click Pay while editing amount #8252
Comments
Another issue with the current buttons is that the user is allowed to edit the amount, even if the invoice contains an amount. The amount should be frozen if the invoice contains an amount, editable otherwise. There is no need for buttons that enable and disable editing. |
The problem is, once the amount is edited, it is stored in the invoice. So after setting an amount, it would become uneditable, even if the original invoice had no amount specified (e.g. address only 'invoice', no-amount LN invoice, etc). We can work around it and keep the original amount around, but only as long as the wallet is open. |
I don't understand what you mean... |
Yes that commit is not blocking edits, it is a fix for this issue. We should create a separate issue for your additional comment.
scan address, amount is unspecified. Edit amount, save invoice -> amount is fixed. |
Maybe I was not clear, but I do understand that it is useful to edit amounts when no amount is specified. this is not the point... The reason why I did not open a separate issue is, I do not see why the editing widgets are useful at all. Their purpose is to switch between editing mode and non-editing mode. But my point is that there is no reason to ever switch between those modes. Thus, I think a deeper rework of InvoiceDialog is needed, that would remove all those buttons, and probably fix all issues at once. |
I can remove the edit mode toggle and just present the invoice amount OR the edit mode if no amount is specified. |
we should save the entered amount if the original invoice did not have an amount. |
see 24a3d6e |
I will try to fix that. any issue I should know? |
allow click Pay while editing amount (if valid)
The text was updated successfully, but these errors were encountered: