Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address on Receive tab goes outside the window #9049

Closed
helpau opened this issue May 13, 2024 · 2 comments
Closed

Address on Receive tab goes outside the window #9049

helpau opened this issue May 13, 2024 · 2 comments
Labels
bug 🐞 gui-qt-desktop Qt ✨ user-interface 🔲
Milestone
4.5.5

Comments

@helpau
Copy link

helpau commented May 13, 2024

Set up: the wallet shows transactions at startup (I imported a random testnet address with transactions when creating the wallet)

  1. Open electrum
  2. Go to Receive
  3. Сlick Create request

Expected: address shown in full
Actual: the element with the address is cropped
image
Walkaround: full screen window
image
@helpau helpau changed the title URI goes outside the window URI on Receive tab goes outside the window May 13, 2024
@helpau helpau changed the title URI on Receive tab goes outside the window Address on Receive tab goes outside the window May 13, 2024
accumulator added a commit that referenced this issue May 29, 2024
@accumulator
qt: fix ReceiveWidget layout (fixes #9049)
21ffe32
@SomberNight
Copy link
Member

With 4159cee, there is a new quirk. The size of the square on the right becomes dependent on its content, notably help texts become huge:

pic1

pic1

pic2

pic2

Layouting the receive tab is starting to become notoriously difficult :P

SomberNight added a commit that referenced this issue May 29, 2024
@SomberNight
Revert "qt: fix ReceiveWidget layout (fixes #9049)"
7f7a785 
This reverts commit 21ffe32.

This layout is difficult to get right. Both the old and the new layout are somewhat buggy.
Reverting this only on the 4.5.x release branch. We can improve it on master.
The old layout has been out there in releases for many months, so it is safer to just use
that in the release branch for now.
SomberNight pushed a commit that referenced this issue May 29, 2024
@accumulator @SomberNight
qt: fix ReceiveWidget layout (fixes #9049)
1e18e53
@SomberNight SomberNight added this to the 4.5.5 milestone May 29, 2024
@helpau
Copy link
Author

helpau commented May 29, 2024

Confirm fix, can't reproduce on 3d189d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 gui-qt-desktop Qt ✨ user-interface 🔲
Projects
None yet
Milestone
4.5.5
Development

No branches or pull requests
2 participants
@SomberNight @helpau