Provide warnings about invalid BIP39 checksum in seed dialog #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will break non-English phrases. It assumes all wordlists are equivalent to BIP39 counterparts, which is not the case for all. |
|
Actually it only assumes that English wordlist is equivalent to it's BIP39 counterpart. If one of the words in phrase is not from English wordlist, it will show this warning: https://github.com/spesmilo/electrum/pull/2130/files#diff-a3125ab4a998d214198f55dfc03353d0R156 . It only checks with English wordlist, not all of them. Also it doesn't prevent using phrase with invalid checksum/wordlist, it only shows warnings. |
This is a lie though. I have recovered my Japanese BIP39 seed before with no problem. |
|
merged manually, after reworking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements what I described in issue #2128 . I've added a small test case to make sure this feature is removed/updated if wordlist bundled with Electrum changes.
Please let me know if you think something should be moved/renamed. I'm not sure keystore.py is a good place for
bip39_is_checksum_valid, but that's the only place I found with other bip39 related functions.