Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ledger old fw segwit crash #3291

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

SomberNight
Copy link
Member

This is a follow-up of 70d23f9 and #3189

[DeviceMgr] scanning devices...
Traceback (most recent call last):
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 245, in on_hw_derivation
    xpub = self.plugin.get_xpub(device_info.device.id_, derivation, xtype, self)
  File "/home/user/wspace/electrum/plugins/ledger/ledger.py", line 488, in get_xpub
    xpub = client.get_xpub(derivation, xtype)
  File "/home/user/wspace/electrum/plugins/ledger/ledger.py", line 62, in get_xpub
    raise Exception("Firmware version too old for Segwit support. Please update at https://www.ledgerwallet.com")
Exception: Firmware version too old for Segwit support. Please update at https://www.ledgerwallet.com

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./electrum", line 373, in <module>
    d.init_gui(config, plugins)
  File "/home/user/wspace/electrum/lib/daemon.py", line 284, in init_gui
    self.gui.main()
  File "/home/user/wspace/electrum/gui/qt/__init__.py", line 248, in main
    if not self.start_new_window(path, self.config.get('url')):
  File "/home/user/wspace/electrum/gui/qt/__init__.py", line 199, in start_new_window
    wallet = wizard.run_and_get_wallet()
  File "/home/user/wspace/electrum/gui/qt/installwizard.py", line 272, in run_and_get_wallet
    self.run(action)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 60, in run
    f(*args)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 87, in new
    self.choice_dialog(title=title, message=message, choices=choices, run_next=self.on_wallet_type)
  File "/home/user/wspace/electrum/gui/qt/installwizard.py", line 91, in func_wrapper
    run_next(*out)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 105, in on_wallet_type
    self.run(action)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 60, in run
    f(*args)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 137, in choose_keystore
    self.choice_dialog(title=title, message=message, choices=choices, run_next=self.run)
  File "/home/user/wspace/electrum/gui/qt/installwizard.py", line 91, in func_wrapper
    run_next(*out)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 60, in run
    f(*args)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 215, in choose_hw_device
    self.choice_dialog(title=title, message=msg, choices=choices, run_next=self.on_device)
  File "/home/user/wspace/electrum/gui/qt/installwizard.py", line 91, in func_wrapper
    run_next(*out)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 231, in on_device
    self.derivation_dialog(f)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 239, in derivation_dialog
    self.line_dialog(run_next=f, title=_('Derivation'), message=message, default=default, test=bitcoin.is_bip32_derivation)
  File "/home/user/wspace/electrum/gui/qt/installwizard.py", line 91, in func_wrapper
    run_next(*out)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 230, in <lambda>
    f = lambda x: self.run('on_hw_derivation', name, device_info, str(x))
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 60, in run
    f(*args)
  File "/home/user/wspace/electrum/lib/base_wizard.py", line 247, in on_hw_derivation
    self.show_error(e)
  File "/home/user/wspace/electrum/gui/qt/util.py", line 190, in show_error
    _('Error'), msg)
  File "/home/user/wspace/electrum/gui/qt/util.py", line 203, in msg_box
    d = QMessageBox(icon, title, text, buttons, parent)
TypeError: arguments did not match any overloaded call:
  QMessageBox(parent: QWidget = None): argument 1 has unexpected type 'Icon'
  QMessageBox(QMessageBox.Icon, str, str, buttons: Union[QMessageBox.StandardButtons, QMessageBox.StandardButton] = QMessageBox.NoButton, parent: QWidget = None, flags: Union[Qt.WindowFlags, Qt.WindowType] = Qt.Dialog|Qt.MSWindowsFixedSizeDialogHint): argument 3 has unexpected type 'Exception'
[Plugins] stopped
[Network] stopping network
[Network] stopped
[Daemon] shutting down network
[Daemon] stopped

@coveralls
Copy link

coveralls commented Nov 13, 2017

Coverage Status

Coverage decreased (-0.009%) to 42.764% when pulling 098c2be on SomberNight:ledger_old_fw_exception1 into f97e812 on spesmilo:master.

@ecdsa ecdsa merged commit e9191ca into spesmilo:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants