Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync android multisig wizard with desktop #5133

Closed
wants to merge 1 commit into from

Conversation

noone2019
Copy link

On Electrum desktop, up to 15 keys can be specified in the multisig wizard. This changes syncs android version with desktop version.

On Electrum desktop, up to 15 keys can be specified in the multisig wizard. This changes syncs android version with desktop version.
@SomberNight
Copy link
Member

I am not sure why it is currently limited to 5 on Android but I imagine there is a reason. @ecdsa any idea?
My guess: the assumption is that mostly QR codes are used to transfer the partial transactions, and QR codes simple cannot fit too much data. (the more cosigners, the larger the partial txn is)

Do you have a multisig wallet you would like to use on Android but can't because of this?

@noone2019
Copy link
Author

Yes. I checked desktop version, it supported up to 15 keys, I decided to use it to create a multisig wallet. Then I tried to use Android version, and then I found that it only supports up to 5 keys.

@noone2019
Copy link
Author

Hey, will you consider merging this?

If the problem is QRCode, a solution is to display a warning to the user on the creation wizard that QRCode might not work. Another solution might be to hide QRCode button when data is larger than a certain amount and instead show a export/copy/share button to export the transaction data.

@ecdsa
Copy link
Member

ecdsa commented Sep 24, 2019

QR code size is indeed a problem.
Also, the slider in the install wizard would become more difficult to use.
I would be curious about the use cases for multisig wallets with more than 5 keys

@ecdsa ecdsa closed this Sep 24, 2019
@noone2019
Copy link
Author

Hey @ecdsa (what a cool username!),

First, thanks for Electrum. Great program.

The slider on mobile is currently in front of the label, which make is half the width of the screen. It can be moved to the line below the label and take the whole screen width.

Anything I say for the reason will not convince you. However, if you think more than 5 keys is useless, why Electrum on desktop have a max of 15?

On desktop I can create up to 15 multisig wallets, and it works, and when I want to use the QRCode for a large transaction, it shows me an error indicating that it is too large for QRCode. It's fair and I can export the text data or save it to a file.

This can happen on mobile too. Users who don't know what they are doing, will have a hard time anyway. And users who want to use a feature in the protocol, can use it.

I opened this because I have created a wallet on desktop, but now I can't use it on mobile, and QRCode is not a problem if I just copy the hex output. This is not to promote more signatures, but to make Electrum on mobile have the same functionality of the desktop version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants