Wizard: do not ask seed type, default to segwit #6806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecdsa
force-pushed
the
make_segwit_default
branch
from
47bec2b
to
470758f
Compare
|
Note that we will need this screen again with taproot, as witness v1 looks to be breaking compat for the address format. How about putting a checkbox/radios/dropdown into the "Options" dialog? |
SomberNight
added
mnemonic/seed 🌼
topic-wizard 🧙♂️
segwit addresses are widely supported today.
ecdsa
force-pushed
the
make_segwit_default
branch
from
470758f
to
641968f
Compare
We will see later if we need that screen again for taproot, and if it can be replaced with more choices in the options dialog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
segwit addresses are widely supported today.