Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature Speed Up #695

Closed
wants to merge 1 commit into from
Closed

Signature Speed Up #695

wants to merge 1 commit into from

Conversation

antonio-fr
Copy link

Slightly modify ECDSA lib, so that signature have a parity bit for yR.
This is as described in ECDSA-SEC1 v2.
Bitcoin signature are 2 times faster. No need to try and test anymore.

Slightly modify ECDSA lib, so that signature have a parity bit for yR.
This is as described in ECDSA-SEC1 v2.
Bitcoin signature are 2 times faster. No need to try and test anymore.
@ecdsa
Copy link
Member

ecdsa commented May 19, 2014

thanks. I will try to merge this as a child class, by looking at the diffs

@ecdsa
Copy link
Member

ecdsa commented May 21, 2014

it would be nice if you could clone the python-ecdsa repo and push your changes there.
that would make code review a lot easier

@antonio-fr
Copy link
Author

With the lot of changes in python-ecdsa lib, I cannot succeed in doing like I wanted. I tried multiple times, but fork & roll-back I can't commit.

I finally made a unidiff from ecdsa lib in electrum 1.9.8 package :
http://pastebin.com/BwryNgC5

@ecdsa
Copy link
Member

ecdsa commented May 30, 2014

python-ecdsa might not be the best choice when it comes to adding optimizations.
maybe we should use pybitcointools instead.

@slush0
Copy link
Contributor

slush0 commented Jul 18, 2014

@ecdsa This reminds me - would you like to use trezor-crypto if we make python binding for it? It is highly optimized and well tested C code, which would speed up Electrum by order of magnitude.

However I remember that you preferred to use pure python in Electrum. So just let me know if you're interested.

@ecdsa
Copy link
Member

ecdsa commented Aug 28, 2014

we can use a c library, if a pure python fallback exists.
this is what tlslite does

@ecdsa
Copy link
Member

ecdsa commented Mar 2, 2017

closing, out of scope

@ecdsa ecdsa closed this Mar 2, 2017
ntninja pushed a commit to ntninja/electron-cash that referenced this pull request Jun 14, 2018
Fix spesmilo#679. User removed a device they were running Electron Cash from.…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants