Do not index request by receiving address #7938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomberNight
reviewed
Aug 15, 2022
ecdsa
force-pushed
the
no_addr_keys_for_requests
branch
5 times, most recently
from
b4199cb
to
9c65cd7
Compare
ecdsa
force-pushed
the
no_addr_keys_for_requests
branch
4 times, most recently
from
5760e79
to
898e1ba
Compare
Replace get_key_for_outgoing_invoice, get_key_for_incoming_request with Invoice.get_id() When a new request is created, reuse addresses of expired requests (fixes #7927) The API is changed for the following commands: get_request, get_invoice, list_requests, list_invoices, delete_request, delete_invoice
ecdsa
force-pushed
the
no_addr_keys_for_requests
branch
from
898e1ba
to
14e96f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not index requests by address.
Instead, use the same get_id method as for invoices.
wallet: in
create_request, reuse use addresses of expired requests (fixes #7927)Separate
wallet.get_requestandwallet.get_request_by_addr,which takes an addressNote that expired requests in
wallet._requests_addr_to_keyget overwritten when a new one is added