Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressSynchronizer: change to use scriptPubKeys instead of addresses #8101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SomberNight
Copy link
Member

This changes the AddressSynchronizer to use scriptPubKeys ("SPKs") instead of addresses.

  • will allow subscribing to scripts that do not have a corresponding address, e.g. OP_RETURNS, p2pk, or bare-multisig
  • the wallet still has addresses, but adb has spks now
    • this results in some awkwardness, e.g. see AddressSynchronizer.get_history, .get_balance, .get_utxos methods
      • I think this is acceptable
    • especially during initial history sync of a wallet, there are lots of address->spk conversions
      • I was seeing noticeably worse performance (CPU load) when syncing wallets, so I made some fixes on master:
      • now the performance looks comparable to old master

@SomberNight SomberNight added the topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant