Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qml: pressing "Esc" on desktop to ~simulate "back" button #8273

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

SomberNight
Copy link
Member

Pressing "Esc" on kivy when testing on desktop closes the active popup/dialog/window/application, similar to what pressing the hw/OS "back" button on Android would do.
I want the same behaviour on qml, as it makes testing more convenient.

This change seems to work; and it seems not to break Android either.
The Popup.CloseOnEscape modifiers need to be removed as they are catching the signal before it could get to the application-level Shortcut, and if I leave them in, one needs to press Esc multiple times to trigger.

@accumulator
Copy link
Member

LGTM

@ecdsa ecdsa merged commit 36687e4 into spesmilo:master Mar 22, 2023
@accumulator
Copy link
Member

accumulator commented Mar 23, 2023

reverted in e7cc2c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants