-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Qt virtual keyboard for Android QML #8275
Conversation
@@ -111,5 +116,8 @@ def stop(self): | |||
self.app.quit() | |||
|
|||
def get_default_language(self): | |||
# On Android this does not return the system locale | |||
# TODO: retrieve through Android API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kivy has some code for Android:
electrum/electrum/gui/kivy/util.py
Line 26 in 7834f6c
def get_default_language() -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I was aware we can do it through jnius, but importing jnius is a bit slow, so I wanted to check if the PyQt QtAndroidExtras module could be used, and if it's faster :)
Edit: seems that the bindings for QtAndroidExtras are very minimal, currently not worth the effort.
…fied from Qt 'default' style
… and parsing to en_GB
As the virtual keyboard will probably be a source of contention, as its behaviour and style is a personal preference, we could opt to make its use a configuration setting. Just like the UI language, we would need to show a message that the app needs to be restarted for the setting to take effect. thoughts? @ecdsa @SomberNight |
no, it should not be optional. we really do not want users to type their seed in a custom keyboard app. |
It's quite non-standard for an app to force-replace the system keyboard with its own. I don't recall seeing it before. So some users are bound to complain. However, using it for seed entry is a matter of security. I concur that we should not let the user enter their seed using the system keyboard (as it might be any custom app). |
This broke running on desktop for me.
Do I need to install something? |
Apparently the |
EDIT(ghost43): see #8256