delete loader to remove specific rows from a target table #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmasterplan
force-pushed
the
feature/delete-rows-loader
branch
from
7638d74
to
b5906dc
Compare
mrmasterplan
force-pushed
the
feature/delete-rows-loader
branch
from
b5906dc
to
6a39485
Compare
|
Your feature looks a bit different, but there are already a "DeleteDataLoader" and the delta handle have a "delete_data" function. This seems very similar in functionality? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Deleting on join is supported in the merge statement. This PR packages that into a loader that deletes keyed rows from a target table.