Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace empty string transformer #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: replace empty string transformer #162

wants to merge 1 commit into from

Conversation

RevioliALJ
Copy link

What type of PR is this? (check all applicable)

  • Feature

Description

Overview

This transformer finds any empty strings in a dataframe and replaces these with null values instead

@RevioliALJ RevioliALJ force-pushed the feature/replace-empty-string-transformer branch from 4d9109e to 9c595a1 Compare March 26, 2024 12:33
@RevioliALJ RevioliALJ force-pushed the feature/replace-empty-string-transformer branch from 9c595a1 to 7388476 Compare March 26, 2024 12:38
MartinBoge
MartinBoge approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@MartinBoge MartinBoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Approved!

JeppeBlixen
JeppeBlixen approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@JeppeBlixen JeppeBlixen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

JeppeBlixen
JeppeBlixen reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@JeppeBlixen JeppeBlixen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to also adding string trimming. It could though be argued that trimming should be its own transformer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeppeBlixen JeppeBlixen JeppeBlixen approved these changes

@MartinBoge MartinBoge MartinBoge approved these changes

@LauJohansson LauJohansson Awaiting requested review from LauJohansson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RevioliALJ @JeppeBlixen @MartinBoge