Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

despf does not consolidate cidrs #126

Closed
bakerjalexander opened this issue Jan 19, 2017 · 7 comments
Closed

despf does not consolidate cidrs #126

bakerjalexander opened this issue Jan 19, 2017 · 7 comments
Assignees

Comments

@bakerjalexander
Copy link

./despf.sh et._spf.pardot.com | ./normalize.sh | ./simplify.sh gives

ip4:13.111.0.0/24
ip4:13.111.1.0/24
ip4:13.111.2.0/24
ip4:13.111.3.0/24
ip4:136.147.135.0/24
ip4:136.147.176.0/24
ip4:136.147.182.0/24
ip4:198.245.81.0/24
ip4:199.122.123.188/30
ip4:199.122.123.192

This correct but not consolidated. It should be merged properly as follows:

13.111.0.0/22
136.147.135.0/24
136.147.176.0/24
136.147.182.0/24
198.245.81.0/24
199.122.123.188/30
199.122.123.192

@bakerjalexander
Copy link
Author

Have you considered using iprange in your script?

@jsarenik
Copy link
Collaborator

@bakerjalexander Thanks for recommendation, I did not know about it before you mentioned it. Do you use it? How?

@jsarenik
Copy link
Collaborator

@bakerjalexander Have a look at #127 please.

@jsarenik jsarenik self-assigned this Jan 20, 2017
@bakerjalexander
Copy link
Author

bakerjalexander commented Jan 20, 2017 via email

@jsarenik
Copy link
Collaborator

@bakerjalexander Thank you! I really appreciate your words and am looking forward to your Perl version! All the best to you!

@jsarenik
Copy link
Collaborator

@bakerjalexander, can this issue be closed now? #127 was merged already into master. Thanks.

@bakerjalexander
Copy link
Author

bakerjalexander commented Jan 26, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants