Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

despf.sh fails to follow "redirect" in SPF records #27

Closed
stevejenkins opened this issue Nov 26, 2015 · 6 comments
Closed

despf.sh fails to follow "redirect" in SPF records #27

stevejenkins opened this issue Nov 26, 2015 · 6 comments
Labels
enhancement

Comments

@stevejenkins
Copy link
Collaborator 

# dig txt facebook.com | grep spf1
facebook.com.           43931   IN      TXT     "v=spf1 redirect=_spf.facebook.com"```

However,

./despf.sh facebook.com

yields no result.

Nor does:

/despf.sh _spf.facebook.com

:(
@jsarenik
Copy link
Collaborator

Thanks! I didn't cope with redirects before and that's why it hasn't been implemented yet.

jsarenik added a commit that referenced this issue Nov 29, 2015
@jsarenik
Add support for redirect
268f889 
This patch tries to fix issue
 despf.sh fails to follow "redirect" in SPF records #27

http://www.openspf.org/SPF_Record_Syntax#redirect
@jsarenik
Copy link
Collaborator

@stevejenkins what about the patch in 268f889 ?

@jsarenik
Copy link
Collaborator 

$ ./despf.sh facebook.com
Getting _spf.facebook.com
ip4:66.220.144.128/25
ip4:66.220.155.0/24
ip4:66.220.157.0/25
ip4:69.171.232.0/25
ip4:69.171.244.0/24
ip4:69.63.178.128/25
ip4:69.63.179.25
ip4:69.63.184.0/25

@jsarenik
Copy link
Collaborator 

$ ./despf.sh _spf.facebook.com
ip4:66.220.144.128/25
ip4:66.220.155.0/24
ip4:66.220.157.0/25
ip4:69.171.232.0/25
ip4:69.171.244.0/24
ip4:69.63.178.128/25
ip4:69.63.179.25
ip4:69.63.184.0/25

@jsarenik jsarenik mentioned this issue Nov 29, 2015
Merged
@jsarenik
Copy link
Collaborator

I know it's not perfect (it should rather read redirect only once and forget anything after it) but it works. Ideas and enhancements are welcome. Feel free to reopen if you are not satisfied with the added functionality.

@stevejenkins
Copy link
Collaborator Author

Working great. :)

jsarenik added a commit that referenced this issue Dec 2, 2015
@jsarenik
Add support for redirect
7e74917 
This patch tries to fix issue
 despf.sh fails to follow "redirect" in SPF records #27

http://www.openspf.org/SPF_Record_Syntax#redirect
@jcbf jcbf mentioned this issue Apr 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsarenik @stevejenkins